Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make reshape and view on Memory produce Arrays and delete wrap #53896

Merged
merged 14 commits into from
Apr 6, 2024
Merged

Make reshape and view on Memory produce Arrays and delete wrap #53896

merged 14 commits into from
Apr 6, 2024

Commits on Mar 29, 2024

  1. make reshape and view on Memory produce Arrays

    @LilithHafner
    LilithHafner committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    cb14345 View commit details
    Browse the repository at this point in the history

  2. delete wrap

    @LilithHafner
    LilithHafner committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    8735009 View commit details
    Browse the repository at this point in the history

  3. add another test

    @LilithHafner
    LilithHafner committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    c2b2a27 View commit details
    Browse the repository at this point in the history

  4. accept that we need to keep jl_genericmemory_slice because we still h… 

    …ave reshape(view(::Memory, ...), ...)
    @LilithHafner
    LilithHafner committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    664335c View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. replace @inbounds with branch

    @LilithHafner
    LilithHafner committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    bc6f772 View commit details
    Browse the repository at this point in the history

  2. restrict to known non-offset-indexed inds

    @LilithHafner
    LilithHafner committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    91542bc View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Apply suggestions from code review 

    Thanks @cafaxo
    @LilithHafner
    LilithHafner committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    6414280 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Update base/genericmemory.jl 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @LilithHafner @vtjnash
    LilithHafner and vtjnash committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    9a713f4 View commit details
    Browse the repository at this point in the history

  2. Update comment

    @LilithHafner
    LilithHafner committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    f16ce69 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. add specific method docstring with warning

    @LilithHafner
    LilithHafner committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    c1586aa View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Fix @eval/docstring interactions

    @LilithHafner
    LilithHafner committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    fb7cf4f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into lh/delete-wrap

    @LilithHafner
    LilithHafner committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    97f1dab View commit details
    Browse the repository at this point in the history

  3. add type annotation

    @LilithHafner
    LilithHafner committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    384f197 View commit details
    Browse the repository at this point in the history

  4. add inference tests

    @LilithHafner
    LilithHafner committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    700ec3e View commit details
    Browse the repository at this point in the history