Delete unnecessary eltype method of CompositeException #54177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```julia julia> eltype(CompositeException()) Any julia> eltype(CompositeException) Any julia> Base.delete_method(@which eltype(CompositeException)) julia> eltype(CompositeException) Any julia> eltype(CompositeException()) Any ```
|
I see this was added in 26a5610#diff-32f72b7e244562a3772085ca0dedcd4b717dd0be3535f73959b31e841f46d0aa, which first made it into v0.7. Testing Julia 1.0, I see that your example still behaves as you demonstrate. Unfortunately, the commit message doesn't give us much to go off, but it's certainly hard to see the problem with removing this. I'll call this a tentative LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
eltype(::Type)method is already any, no need to specialize onType{CompositeException}.