Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes to colonful reshape #54261

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixes to colonful reshape #54261

wants to merge 3 commits into from
+34 −4

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Apr 26, 2024

Fixes #54245

@nsajko nsajko added domain:arrays [a, r, r, a, y, s] kind:bugfix This change fixes an existing bug labels Apr 26, 2024
nhz2
nhz2 approved these changes Apr 28, 2024
View reviewed changes
Copy link
Contributor

@nhz2 nhz2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

N5N3
N5N3 reviewed Apr 29, 2024
View reviewed changes
base/reshapedarray.jl Outdated Show resolved Hide resolved
@nsajko
fixes to colonful reshape
77a2463 
In several different situations `reshape` had thrown `DivideError`
instead of returning a correct result or throwing.

Fixes JuliaLang#54245
@nsajko
also add some type assertions for good measure
0dd2390
@nsajko
Copy link
Contributor Author

nsajko commented May 6, 2024

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N5N3 N5N3 N5N3 left review comments

@nhz2 nhz2 nhz2 approved these changes

Assignees
No one assigned
Labels
domain:arrays [a, r, r, a, y, s] kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

colonful reshape may spuriously throw DivideError
3 participants
@nsajko @N5N3 @nhz2