REPL: fix hinting without expanding user #54311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
added
stdlib:REPL
|
This looks like a nice change to me 😃 |
IanButterworth
force-pushed
the
ib/hint_expanduser
branch
3 times, most recently
from
6eaed21
to
f83b552
Compare
|
This is going to require adding the |
IanButterworth
force-pushed
the
ib/hint_expanduser
branch
3 times, most recently
from
2010944
to
bc17ff1
Compare
IanButterworth
force-pushed
the
ib/hint_expanduser
branch
from
bc17ff1
to
158139d
Compare
59 tasks
|
I found a little weird behavior but it exists before this PR.
That can be for another PR |
This was referenced May 7, 2024
KristofferC
pushed a commit
that referenced
this pull request
May 20, 2024
Fixes #53884 Hints will show without expanding `~`, then a tab will complete the shown hint, then a second tab on the resulting valid path expands `~`. I think it makes sense? https://github.com/JuliaLang/julia/assets/1694067/05a4fa97-2a85-4f90-8591-162256cf0704 (cherry picked from commit 1221160)
KristofferC
pushed a commit
that referenced
this pull request
May 23, 2024
Fixes #53884 Hints will show without expanding `~`, then a tab will complete the shown hint, then a second tab on the resulting valid path expands `~`. I think it makes sense? https://github.com/JuliaLang/julia/assets/1694067/05a4fa97-2a85-4f90-8591-162256cf0704 (cherry picked from commit 1221160)
KristofferC
removed
the
backport 1.11
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Jul 12, 2024
Fixes JuliaLang#53884 Hints will show without expanding `~`, then a tab will complete the shown hint, then a second tab on the resulting valid path expands `~`. I think it makes sense? https://github.com/JuliaLang/julia/assets/1694067/05a4fa97-2a85-4f90-8591-162256cf0704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53884
Hints will show without expanding
~, then a tab will complete the shown hint, then a second tab on the resulting valid path expands~. I think it makes sense?Screen.Recording.2024-04-29.at.9.54.40.PM.mov