Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump LLVM to v18 #54848

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Bump LLVM to v18 #54848

wants to merge 19 commits into from

Conversation

Zentrik
Copy link
Contributor

@Zentrik Zentrik commented Jun 18, 2024

No description provided.

@Zentrik Zentrik closed this Jun 18, 2024
@Zentrik Zentrik added external dependencies Involves LLVM, OpenBLAS, or other linked libraries compiler:llvm For issues that relate to LLVM labels Jun 18, 2024
@Zentrik Zentrik changed the title Bump LLVM to v18 [TEST] Bump LLVM to v18 Jun 20, 2024
@Zentrik Zentrik reopened this Jun 20, 2024
src/disasm.cpp Outdated Show resolved Hide resolved
@giordano giordano added domain:building Build system, or building Julia or its dependencies stdlib:JLLs labels Jun 20, 2024
@Zentrik
Copy link
Contributor Author

Zentrik commented Jun 20, 2024

Bit confused why windows won't start building

@giordano
Copy link
Contributor

I think there's something broken with the CI setup. CC: @staticfloat

@gbaraldi
Copy link
Member

This fixes the llvmpasses tests

diff --git a/test/llvmpasses/pipeline-prints.ll b/test/llvmpasses/pipeline-prints.ll
index babd26c797..ecb7095302 100644
--- a/test/llvmpasses/pipeline-prints.ll
+++ b/test/llvmpasses/pipeline-prints.ll
@@ -298,12 +298,12 @@ attributes #2 = { inaccessiblemem_or_argmemonly }

 ; COM: Loop simplification makes the exit condition obvious
 ; AFTERLOOPSIMPLIFICATION: L35.lr.ph:
-; AFTERLOOPSIMPLIFICATION-NEXT: add nuw nsw
+; AFTERLOOPSIMPLIFICATION: add nuw nsw

 ; COM: Scalar optimization removes the previous add from the preheader
-; AFTERSCALAROPTIMIZATION: L35.preheader:
+; AFTERSCALAROPTIMIZATION: L35.lr.ph:
 ; AFTERSCALAROPTIMIZATION-NOT: add nuw nsw
-; AFTERSCALAROPTIMIZATION-NEXT: br label %L35
+; AFTERSCALAROPTIMIZATION: br label %L35

 ; COM: Vectorization does stuff
 ; AFTERVECTORIZATION: vector.body

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 24, 2024

llvm/llvm-project#78251

…e public julia.h header. That stops us having to either vendor or cache the result of llvm-version.h
@gbaraldi gbaraldi marked this pull request as ready for review July 2, 2024 14:43
@gbaraldi
Copy link
Member

gbaraldi commented Jul 2, 2024

The windows build is segfaulting in

#0  0x00007ff8e4f70de5 in ntdll!RtlVirtualUnwind () from /c/Windows/SYSTEM32/ntdll.dll
#1  0x00007ff8e4f70ccb in ntdll!RtlVirtualUnwind () from /c/Windows/SYSTEM32/ntdll.dll
#2  0x00007ff8e3ee3bd8 in RtlVirtualUnwind () from /c/Windows/System32/KERNEL32.DLL
#3  0x00007ff8bb29cfed in jl_unw_step (cursor=0xba5690, from_signal_handler=0, ip=<synthetic pointer>,
    sp=<synthetic pointer>) at C:/msys64/home/vboxuser/julia/src/stackwalk.c:523
#4  jl_unw_stepn (cursor=cursor@entry=0xba5690, bt_data=bt_data@entry=0x42b0080, bt_size=bt_size@entry=0xba51b8,
    sp=sp@entry=0x0, maxsize=maxsize@entry=80000, skip=0, skip@entry=3, ppgcstack=ppgcstack@entry=0xba51b0,
    from_signal_handler=from_signal_handler@entry=0) at C:/msys64/home/vboxuser/julia/src/stackwalk.c:99
#5  0x00007ff8bb29d752 in rec_backtrace (bt_data=0x42b0080, maxsize=maxsize@entry=80000, skip=skip@entry=2)
    at C:/msys64/home/vboxuser/julia/src/stackwalk.c:222
#6  0x00007ff8bb264313 in record_backtrace (ptls=0x3d71d10, skip=skip@entry=1)
    at C:/msys64/home/vboxuser/julia/src/task.c:412
#7  0x00007ff8bb264a85 in ijl_throw (e=0x13b7c0c0) at C:/msys64/home/vboxuser/julia/src/task.c:771
#8  0x00007ff8bb2cfdb9 in ijl_errorf (
    fmt=fmt@entry=0x7ff8bb482178 <flisp_system_image+362104> "Type %s does not have a definite size.")
    at C:/msys64/home/vboxuser/julia/src/rtutils.c:77
#9  0x00007ff8bb24d3a8 in jl_f_sizeof (F=<optimized out>, args=<optimized out>, nargs=<optimized out>)
    at C:/msys64/home/vboxuser/julia/src/builtins.c:531

@giordano
Copy link
Contributor

giordano commented Jul 2, 2024

Was libllvm_jll updated to 18.1.7+2? That includes llvm/llvm-project#88172 which should fix WIndows issues according to JuliaLang/llvm-project#30 (comment).

@gbaraldi
Copy link
Member

gbaraldi commented Jul 2, 2024

This doesn't have the new LLVM build yet. I was fixing the embedding thing mostly

@Zentrik
Copy link
Contributor Author

Zentrik commented Jul 2, 2024

Oops, 64 bit windows builds on the branch with head Zentrik/llvm-project@b557165 not with JuliaLang/llvm-project#30.

EDIT: These are the changes, JuliaLang/llvm-project@julia-release/18.x...Zentrik:llvm-project:windows-fix3. I just reverted a bunch of commits.

@gbaraldi
Copy link
Member

gbaraldi commented Jul 2, 2024

Do we know which one broke it?

@Zentrik
Copy link
Contributor Author

Zentrik commented Jul 2, 2024

I have no clue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:llvm For issues that relate to LLVM domain:building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries stdlib:JLLs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants