Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggressive constprop in mapslices #54928

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Aggressive constprop in mapslices #54928

merged 1 commit into from
Jun 25, 2024

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Jun 25, 2024

This helps improve type-inference, e.g. the return type in the following call is concretely inferred after this:

julia> @inferred (() -> mapslices(sum, reshape(collect(1:16), 2, 2, 2, 2), dims=(3,4)))()
2×2×1×1 Array{Int64, 4}:
[:, :, 1, 1] =
 28  36
 32  40

This should address the first concern in #54918

@jishnub jishnub added performance Must go faster domain:arrays [a, r, r, a, y, s] compiler:inference Type inference labels Jun 25, 2024
@KristofferC KristofferC merged commit 8ee98b2 into master Jun 25, 2024
10 checks passed
@KristofferC KristofferC deleted the jishnub/constprop_mapslices branch June 25, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkarrasch dkarrasch dkarrasch approved these changes

Assignees
No one assigned
Labels
compiler:inference Type inference domain:arrays [a, r, r, a, y, s] performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jishnub @dkarrasch @KristofferC