Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create GC TLS #55086

Merged
merged 1 commit into from
Jul 10, 2024
Merged

create GC TLS #55086

merged 1 commit into from
Jul 10, 2024

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Jul 9, 2024

Encapsulates all relevant GC thread-local-state into a separate structure.

Motivation is that MMTk will have its own version of GC thread-local-state, so doesn't need all of the Julia GC TLS.

In the future, folks who would be using MMTk would be setting a pre-processor flag which would lead to either the stock Julia GC TLS or MMTk's GC TLS to be included in julia_threads.h.

I.e., we would have something like:

#ifdef MMTK_GC
#include <include/mmtk-gc-tls.h>
#else
#include "gc-tls.h"
#endif

where each of these files contains a GC TLS structure definition.

@d-netto d-netto added the GC Garbage collector label Jul 9, 2024
@d-netto d-netto requested review from kpamnany and gbaraldi July 9, 2024 09:59
@d-netto d-netto force-pushed the dcn-gc-tls branch 4 times, most recently from c41a42d to f4267f8 Compare July 9, 2024 23:31
Copy link
Contributor

@kpamnany kpamnany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/julia_threads.h Outdated Show resolved Hide resolved
@d-netto d-netto merged commit faf17eb into master Jul 10, 2024
7 checks passed
@d-netto d-netto deleted the dcn-gc-tls branch July 10, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GC Garbage collector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants