Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support i386 option for absolute baseline x86 support #7103

Merged
merged 1 commit into from
Jun 3, 2014
Merged

Conversation

Keno
Copy link
Member

@Keno Keno commented Jun 3, 2014

Fixes #6715. @nalimilan Does this work for you?

@nalimilan
Copy link
Member

Cool! I thought it would have required many more changes.

I can't try it myself since I only have an i5 CPU, but I'll ask the Fedora user who tested it. I guess if developers are OK you should just merge the PR, I'll confirm later if it works.

@ViralBShah
Copy link
Member

This is useful to have for Debian too, and distros should probably build with i386, right? Is this something that can be set when Julia is started? It's ok if the julia binaries are i386, but generated code should be native.

Cc: @sebastien-villemot

@Keno
Copy link
Member Author

Keno commented Jun 3, 2014

No, this needs to be set at compile time and needs to be the same for the jitted code since llvm switches calling conventions on us depending on what CPU feature are available.

@JeffBezanson
Copy link
Sponsor Member

Distros vary in their policies; some specifically aim to optimize code for modern cpus.

@Keno
Copy link
Member Author

Keno commented Jun 3, 2014

Ok, I'll merge this, since the main point of this was to let people know if was happening (plus my julia repos are so far off master, that I need to push everything to a branch first to make sure I don't accidentally commit something I shouldn't ;) )

Keno added a commit that referenced this pull request Jun 3, 2014
Support `i386`  option for absolute baseline x86 support
@Keno Keno merged commit a987ced into master Jun 3, 2014
@nalimilan
Copy link
Member

Oh, and for x86_64 builds, should distributions also pass i386 and it will be understood correctly (i.e. SSE and SSE2 can still be enabled)? Or should an x86_64 target be also added? Sorry, I don't know where to look to see a list of targets accepted by LLVM.

@nalimilan
Copy link
Member

@Keno Ideas? ^

@Keno
Copy link
Member Author

Keno commented Jun 6, 2014

No in theory it should just work. I do seem to recall however that least extensive x86_64 has all the core2 features, but I may be wrong there.

@nalimilan
Copy link
Member

@Keno OK, will try. But Core 2 CPUs support e.g. SSE3 and SSSE3, contrary to older x86_64 CPUs.

@JeffBezanson JeffBezanson deleted the kf/x86option branch October 25, 2014 17:27
PallHaraldsson added a commit to PallHaraldsson/julia that referenced this pull request Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support JULIA_CPU_TARGET=x86
4 participants