-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support i386
option for absolute baseline x86 support
#7103
Conversation
Cool! I thought it would have required many more changes. I can't try it myself since I only have an i5 CPU, but I'll ask the Fedora user who tested it. I guess if developers are OK you should just merge the PR, I'll confirm later if it works. |
This is useful to have for Debian too, and distros should probably build with Cc: @sebastien-villemot |
No, this needs to be set at compile time and needs to be the same for the jitted code since llvm switches calling conventions on us depending on what CPU feature are available. |
Distros vary in their policies; some specifically aim to optimize code for modern cpus. |
Ok, I'll merge this, since the main point of this was to let people know if was happening (plus my julia repos are so far off master, that I need to push everything to a branch first to make sure I don't accidentally commit something I shouldn't ;) ) |
Support `i386` option for absolute baseline x86 support
Oh, and for x86_64 builds, should distributions also pass |
@Keno Ideas? ^ |
No in theory it should just work. I do seem to recall however that least extensive x86_64 has all the |
@Keno OK, will try. But Core 2 CPUs support e.g. SSE3 and SSSE3, contrary to older x86_64 CPUs. |
JuliaLang#7103 [skip ci]
Fixes #6715. @nalimilan Does this work for you?