restore broadcasting array±scalar operations #7226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay to merge, as per apparent consensus in #5810? |
|
Any reason for these not to be AbstractArrays? |
|
No, they can be |
JeffBezanson
added a commit
that referenced
this pull request
Jun 17, 2014
restore broadcasting array±scalar operations
|
What a relief! |
Closed
simonster
added a commit
to JuliaStats/DataArrays.jl
that referenced
this pull request
Jun 19, 2014
Remove deprecations, restore NA broadcasting methods, and add tests
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recently discussed in #5810, the deprecation of broadcasting
+and-for arrays and scalars, while theoretically removing some ambiguity for the case of matrix+scalar (though it is not clear that this has ever been a problem in practice), seems to cause more annoyance than it is worth, and will be a continual headache for users migrating from NumPy, Matlab, etc.This patch restores those functions.