Performance: float(AbstractArray) and complex(AbstractArray) #7308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test_profile() function used to demonstrate https://github.com/timholy/ProfileView.jl shows a performance hit from an anonymous function at abstractarray.jl line 319, which is complex(A::AbstractArray) . map_promote() in that function contains an anonymous function that creates a performance hit. Switching to a named function speeds test_profile() by about 3.3x on my 64-bit Linux system. cc: @tholy
Profile View example with current float(A::AbstractArray) and complex(A::AbstractArray) --
http://nbviewer.ipython.org/gist/catawbasam/1fd6a82605a54b052425
Profile View example with proposed float(A::AbstractArray) and complex(A::AbstractArray) --
http://nbviewer.ipython.org/gist/catawbasam/e1768937952565213561