Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: float(AbstractArray) and complex(AbstractArray) #7308

Merged
merged 1 commit into from Jun 18, 2014
Merged

Performance: float(AbstractArray) and complex(AbstractArray) #7308

merged 1 commit into from Jun 18, 2014

Conversation

catawbasam
Copy link
Contributor

The test_profile() function used to demonstrate https://github.com/timholy/ProfileView.jl shows a performance hit from an anonymous function at abstractarray.jl line 319, which is complex(A::AbstractArray) . map_promote() in that function contains an anonymous function that creates a performance hit. Switching to a named function speeds test_profile() by about 3.3x on my 64-bit Linux system. cc: @tholy

Profile View example with current float(A::AbstractArray) and complex(A::AbstractArray) --
http://nbviewer.ipython.org/gist/catawbasam/1fd6a82605a54b052425

Profile View example with proposed float(A::AbstractArray) and complex(A::AbstractArray) --
http://nbviewer.ipython.org/gist/catawbasam/e1768937952565213561

@ivarne
Copy link
Sponsor Member

ivarne commented Jun 18, 2014

Probably you intended to ping @timholy

@catawbasam
Copy link
Contributor Author

@ivarne : yes. How does that work?

@timholy
Copy link
Sponsor Member

timholy commented Jun 18, 2014

You did it fine except you wrote it as tholy rather than timholy.

Off topic, but thanks for pinging me: before now, I hadn't realized that ProfileView works exactly as intended when viewed through the notebook viewer. When used directly in IJulia, there's still something not updating, and I don't understand why. I'll file an IJulia issue.

JeffBezanson added a commit that referenced this pull request Jun 18, 2014
Performance: float(AbstractArray) and  complex(AbstractArray)
@JeffBezanson JeffBezanson merged commit 25eddd3 into JuliaLang:master Jun 18, 2014
@catawbasam
Copy link
Contributor Author

wrt to ProfileView in IJulia, it seems to work fine in FireFox on 64-bit Linux. On 64-bit Windows 7, IJulia within Chrome does not display the function info properly. And thanks for creating ProfileView. It's a fun tool.

@timholy
Copy link
Sponsor Member

timholy commented Jun 19, 2014

For further discussion of the off-topic IJulia issue: JuliaLang/IJulia.jl#196
(but thanks for the tip, @catawbasam! I'll go check that out.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants