WIP: use shared symlink pkg cache on Windows newer than XP #7361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiahao
force-pushed
the
master
branch
3 times, most recently
from
6c7c7e3
to
1a4c02f
Compare
|
bump. should this be merged, now that we're in a 0.4 projects window? |
|
Sure, let's see what happens. I think I fixed the issue in libuv that was preventing NTFS junctions from working robustly. |
vtjnash
added a commit
that referenced
this pull request
Dec 13, 2014
WIP: use shared symlink pkg cache on Windows newer than XP
tkelman
added a commit
that referenced
this pull request
Dec 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is following up on something @kmsquire asked me to do in #7274, now that symlinks sort of work on Windows newer than XP. Symlinks to files require admin rights in Vista/7/8, so for symlink to a directory we went with NTFS junctions instead.
Putting this up for review first, I'd like to do a bit more testing and verify that there are no bad interactions with #7055 for NTFS junctions. Also see #4396 for earlier discussion.