Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bigfloat itrunc error #9138

Merged
merged 1 commit into from
Nov 24, 2014
Merged

Conversation

simonbyrne
Copy link
Contributor

Currently itrunc(2.7) == 3. This fixes it, and some errors in the Ziggurat tables that arose. See #9133.

tkelman added a commit that referenced this pull request Nov 24, 2014
@tkelman tkelman merged commit 0d545b8 into JuliaLang:master Nov 24, 2014
@tkelman
Copy link
Contributor

tkelman commented Nov 24, 2014

good catch, thanks for splitting this out

@simonbyrne
Copy link
Contributor Author

I think the to_mpfr function might be 0.4 only, but you can just replace that call by a constant 1.

@tkelman
Copy link
Contributor

tkelman commented Nov 25, 2014

to_mpfr exists in 0.3.3.

  | | |_| | | | (_| |  |  Version 0.3.3 (2014-11-23 20:19 UTC)
 _/ |\__'_|_|_|\__'_|  |
|__/                   |  i686-w64-mingw32

julia> Base.MPFR.to_mpfr(Base.RoundToZero)
1

tkelman pushed a commit that referenced this pull request Dec 2, 2014
@tkelman
Copy link
Contributor

tkelman commented Dec 2, 2014

Backported in d7c9518 - I forgot the --date though, whoops. Had to fiddle with it to get it to apply via curl https://github.com/JuliaLang/julia/pull/9138.patch | sed 's/UInt/Uint/g' | git apply --whitespace=fix.

@simonbyrne simonbyrne deleted the bigfloat-itrunc branch March 10, 2015 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants