Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable raise test on windows again #9570

Merged
merged 1 commit into from Jan 4, 2015
Merged

disable raise test on windows again #9570

merged 1 commit into from Jan 4, 2015

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Jan 3, 2015

@tkelman
Copy link
Contributor Author

tkelman commented Jan 3, 2015

I re-ran the Travis job about a half dozen times for this, couldn't reproduce the segfaults there.

I reproduced the Windows issues locally by running the same build script AppVeyor uses, and it looks like deleting sys.dll makes the problem go away. So that could be a temporary CI bandaid for this.

@tkelman tkelman mentioned this pull request Jan 3, 2015
Merged
timholy referenced this pull request Jan 3, 2015
@vtjnash
fix #9544. call jl_throw directly in JL_SIGATOMIC_END rather than ind…
40c2225 
…irectly through raise
@tkelman
Copy link
Contributor Author

tkelman commented Jan 3, 2015

On the AppVeyor side, it might be something different - I'm pursuing locally that I might need a rebuilt version of LLVM 3.3? The binaries that I have posted at https://sourceforge.net/projects/juliadeps-win/files/ that get downloaded (and cached) on AppVeyor were from 4-6 months ago, I guess we've added a patch or something since then?

edit: nevermind, small sample sizes just misleading me

@tkelman tkelman closed this Jan 4, 2015
@tkelman tkelman deleted the tk/raise-test branch January 4, 2015 05:02
@tkelman tkelman restored the tk/raise-test branch January 4, 2015 06:09
@tkelman tkelman reopened this Jan 4, 2015
@tkelman tkelman changed the title WIP: disable raise test disable raise test on windows again Jan 4, 2015
@tkelman
Copy link
Contributor Author

tkelman commented Jan 4, 2015

This made appveyor pass on win32 https://ci.appveyor.com/project/StefanKarpinski/julia/build/1.0.1146/job/cwyuovgd4q6qd5jx so I'm tempted to merge it, @vtjnash okay with you?

tkelman added a commit that referenced this pull request Jan 4, 2015
@tkelman
Merge pull request #9570 from JuliaLang/tk/raise-test
d8a1363 
disable raise test on windows again

[av skip]
@tkelman tkelman merged commit d8a1363 into master Jan 4, 2015
@tkelman tkelman deleted the tk/raise-test branch January 4, 2015 08:49
@tkelman tkelman added windows Affects only Windows test This change adds or pertains to unit tests labels Jan 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test This change adds or pertains to unit tests windows Affects only Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tkelman