rename beginswith to startswith (#9578) #9583
Conversation
| @@ -93,7 +93,7 @@ function startswith{T<:String}(stream::IO, ss::Vector{T}; kws...) | |||
| end | |||
|
|
|||
| function startswith(stream::IO, r::Regex; eat = true, padding = false) | |||
| @assert beginswith(r.pattern, "^") | |||
| @assert Base.startswith(r.pattern, "^") | |||
There was a problem hiding this comment.
Why do you suddenly prefix with Base.?
There was a problem hiding this comment.
The Markdown module has already defined a function named startswith, so the name will be overridden without Base..
There was a problem hiding this comment.
Ideally the Markdown.startswith () method should be renamed now?
@one-more-minute, isn't that your code?
There was a problem hiding this comment.
Yup – I'm fine with a rename if we can come up with one, but since this is self-contained (and isn't adding methods to Base.startswith) it doesn't seem like too much of a problem.
There was a problem hiding this comment.
It's purely a stylistic issue, but might cause confusion when improving Markdown, and one might end up using the wrong function.
There was a problem hiding this comment.
Yes, that's a fair point. I guess I could change it to beginswith ;) Either way I'll add it to my list of tasks when I'm updating Markdown.jl
|
The new name is fine with me. Thanks for doing all the renaming yourself. Let's see what people think. |
|
+1 for renaming to |
|
I like |
|
+1 |
ref: #9578