Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent downgrading on old version in mirror #889

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Prevent downgrading on old version in mirror #889

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f5d3ca
fix: should prevent downloading and downgrading when version on a mir…
ghyatzo Apr 6, 2024
08f318a
fix: changes to asking the user for input on downgrade to allow switc…
ghyatzo Apr 15, 2024
cfc4214
fix: avoid downgrade in non-interactive mode
ghyatzo Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 46 additions & 32 deletions src/command_selfupdate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ pub fn run_command_selfupdate(paths: &GlobalPaths) -> Result<()> {
use crate::utils::get_juliaserver_base_url;
use crate::{get_juliaup_target, get_own_version};
use anyhow::{anyhow, bail};
use dialoguer::{theme::SimpleTheme, Confirm};
use is_terminal::IsTerminal;

update_version_db(paths).with_context(|| "Failed to update versions db.")?;

Expand All @@ -33,7 +35,7 @@ pub fn run_command_selfupdate(paths: &GlobalPaths) -> Result<()> {
),
};

eprintln!("Checking for self-updates");
eprintln!("Checking for self-updates on channel: {}", juliaup_channel);

let version_url = juliaupserver_base.join(version_url_path).with_context(|| {
format!(
Expand All @@ -44,48 +46,60 @@ pub fn run_command_selfupdate(paths: &GlobalPaths) -> Result<()> {

let version = download_juliaup_version(&version_url.to_string())?;

if version < get_own_version().unwrap() {
// If not in iteractive mode, avoid downgrading automatically
if !std::io::stdin().is_terminal() {
return Ok(());
}

eprintln!(
"You are trying to install version: {}-{}, but the currently installed version is newer",
juliaup_channel, version
);
match Confirm::with_theme(&SimpleTheme)
.with_prompt("Do you want to continue?")
.default(false)
.interact()?
{
true => {} // continue
false => return Ok(()),
}
}

config_file.self_data.last_selfupdate = Some(chrono::Utc::now());

save_config_db(&mut config_file).with_context(|| "Failed to save configuration file.")?;

if version == get_own_version().unwrap() {
eprintln!(
"Juliaup unchanged on channel '{}' - {}",
juliaup_channel, version
);
} else {
let juliaup_target = get_juliaup_target();
let juliaup_target = get_juliaup_target();

let juliaupserver_base =
get_juliaserver_base_url().with_context(|| "Failed to get Juliaup server base URL.")?;
let juliaupserver_base =
get_juliaserver_base_url().with_context(|| "Failed to get Juliaup server base URL.")?;

let download_url_path =
format!("juliaup/bin/juliaup-{}-{}.tar.gz", version, juliaup_target);
let download_url_path = format!("juliaup/bin/juliaup-{}-{}.tar.gz", version, juliaup_target);

let new_juliaup_url = juliaupserver_base
.join(&download_url_path)
.with_context(|| {
format!(
"Failed to construct a valid url from '{}' and '{}'.",
juliaupserver_base, download_url_path
)
})?;
let new_juliaup_url = juliaupserver_base
.join(&download_url_path)
.with_context(|| {
format!(
"Failed to construct a valid url from '{}' and '{}'.",
juliaupserver_base, download_url_path
)
})?;

let my_own_path = std::env::current_exe()
.with_context(|| "Could not determine the path of the running exe.")?;
let my_own_path = std::env::current_exe()
.with_context(|| "Could not determine the path of the running exe.")?;

let my_own_folder = my_own_path
.parent()
.ok_or_else(|| anyhow!("Could not determine parent."))?;
let my_own_folder = my_own_path
.parent()
.ok_or_else(|| anyhow!("Could not determine parent."))?;

eprintln!(
"Found new version {} on channel {}.",
version, juliaup_channel
);
eprintln!(
"Found new version {} on channel {}.",
version, juliaup_channel
);

download_extract_sans_parent(&new_juliaup_url.to_string(), &my_own_folder, 0)?;
eprintln!("Updated Juliaup to version {}.", version);
}
download_extract_sans_parent(&new_juliaup_url.to_string(), &my_own_folder, 0)?;
eprintln!("Updated Juliaup to version {}.", version);

Ok(())
}
Expand Down