Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update character widths from Unifont 8.0.01 #51

Merged
merged 2 commits into from
Jul 6, 2015
Merged

Conversation

jiahao
Copy link
Collaborator

@jiahao jiahao commented Jun 29, 2015

Ref #50

@stevengj
Copy link
Member

The Ruby oddness strikes again. A difference in the utf8proc_stage2table, it seems like, but looking at the Ruby script I'm not sure why this would be non-deterministic.

@StefanKarpinski, you used to be a Ruby hacker, right? Any idea why the data_generator.rb script would be non-deterministic?

@stevengj
Copy link
Member

Note that e.g. u+06de now has a charwidth of 2 with this patch. This seems odd to me: on my terminal, ۞ seems to have a charwidth of 1.

@jiahao
Copy link
Collaborator Author

jiahao commented Jun 30, 2015

Unifont 8.0.01 does define U+06DE to have fullwidth (1024 units); 7.0.06 gave it a negative RBearing of -1024 units so that it had width 0.

screen shot 2015-06-30 at 4 15 48 pm

@StefanKarpinski
Copy link
Member

Hashes are unordered in Ruby 1.8.x (but not, I believe in 1.9.x). Perhaps that could affect things?

@stevengj
Copy link
Member

stevengj commented Jul 1, 2015

@StefanKarpinski, I figured that the order of a hash would be undefined, but I'm not seeing where the script would depend on this. What am I missing?

@stevengj
Copy link
Member

stevengj commented Jul 1, 2015

Has anyone been able to reproduce this failure locally? I tried using the same Ruby version as on Travis (ruby 1.9.3p551, from #48), but it still passes.

@stevengj
Copy link
Member

stevengj commented Jul 1, 2015

My inclination is to merge this and to open a separate issue for the data-generation Travis test, since that was a problem prior to this patch.

@ScottPJones
Copy link
Contributor

How difficult is this Ruby code to understand? We've got a much better language right here!

@stevengj
Copy link
Member

stevengj commented Jul 2, 2015

I don't have the time to rewrite it from scratch right now, do you? Also, it is frustrating to rewrite otherwise-working code rather than fix something that is probably a one-line fix, if only I could reproduce the problem.

@stevengj stevengj mentioned this pull request Jul 2, 2015
4 tasks
@ScottPJones
Copy link
Contributor

It is really that complicated? I'm just asking, not trying to pressure you (or anybody) into rewriting it.
I was just wondering if the effort of finding that bug would be more than getting something in Julia that would save time in the future (and not require a person with Ruby expertise).

@StefanKarpinski
Copy link
Member

The Ruby code is pretty straightforward, but it's also unclear why it would be nondeterministic. I don't think completely rewriting it is the answer.

stevengj added a commit that referenced this pull request Jul 6, 2015
Update character widths from Unifont 8.0.01
@stevengj stevengj merged commit c35d1bf into master Jul 6, 2015
@stevengj
Copy link
Member

stevengj commented Jul 6, 2015

Merged since the Ruby problem on Travis is not a regression in this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants