Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use versioned Unicode data URLs #78

Merged
merged 1 commit into from
Jul 13, 2016
Merged

Use versioned Unicode data URLs #78

merged 1 commit into from
Jul 13, 2016

Conversation

petercolberg
Copy link
Contributor

This ensures the tests keep working when a new Unicode version is released.

This ensures the tests keep working when a new Unicode version is released.
@stevengj stevengj merged commit 11b84e2 into JuliaStrings:master Jul 13, 2016
stevengj added a commit that referenced this pull request Jul 13, 2016
@petercolberg
Copy link
Contributor Author

petercolberg commented Jul 13, 2016

That’s interesting, the author name and date of my commit are wrong:

commit 11b84e2de124be3c5931ee567e2f21b0aa08f810
Author:     petercolberg <peter@colberg.org>
AuthorDate: Wed Jul 13 12:40:59 2016 -0400
Commit:     Steven G. Johnson <stevenj@mit.edu>
CommitDate: Wed Jul 13 12:40:59 2016 -0400

This is the commit from the pull request:

commit 61d946657e3379143a41665e09f46cba2a977791 (ucd)
Author:     Peter Colberg <peter@colberg.org>
AuthorDate: Wed Jul 13 12:27:39 2016 -0400
Commit:     Peter Colberg <peter@colberg.org>
CommitDate: Wed Jul 13 12:27:39 2016 -0400

Any idea why this is happening?

@petercolberg
Copy link
Contributor Author

The same issue with the merge of #73. It seems github started discarding the author’s metadata.

@StefanKarpinski
Copy link
Member

The author is correct – it's you. The committer is the person who applied the commit, which in this case is @stevengj. This is the way commits appear in history when using GitHub's online PR squashing functionality, which avoids creating a merge commit (probably why @stevengj did it that way).

@petercolberg
Copy link
Contributor Author

This is the way commits appear in history when using GitHub's online PR squashing functionality, which avoids creating a merge commit (probably why @stevengj did it that way).

That’s it. I set Name on my profile to hopefully have the correct author name for future squashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants