C99 compatibility of bool declaration

[ennorehling]

In utf8proc.h, true, false and bool are defined. They are reserved keywords in modern C (not just C++), and clash with those definitions.

#  ifndef __cplusplus
typedef unsigned char utf8proc_bool;
enum {false, true};
#  else
typedef bool utf8proc_bool;
#  endif

This breaks compilation on MSVC, and there is no preprocessor macro I can define to let utf8proc.h know that bool is already defined elsewhere. Aside from the C99 standard, it also breaks if the utf8proc.h header is included after one that also defines false and true (like stdbool.h, which can be tested for with the __bool_true_false_are_defined feature macro).

[stevengj]

It doesn't define bool, but it does define false and true, and you're right that these conflict with stdbool.h in C99.

[stevengj]

We shouldn't define false and true at all in the public header file, since we only use these internally.

[stevengj]

(They are not technically reserved words in C, as I understand it; it should be safe to define them in utf8proc.c, where we don't include stdbool.h for MSVC?)

[stevengj]

On non-MS compilers, we include stdbool.hin C. We didn't do so on MSVC because MS didn't provide that header...has that been fixed?

[stevengj]

Ah, I see that they finally fixed this in 2013: https://blogs.msdn.microsoft.com/vcblog/2013/07/19/c99-library-support-in-visual-studio-2013/

[stevengj]

Should be fixed in master.