Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead links #524

Closed
logankilpatrick opened this issue Dec 24, 2019 · 8 comments
Closed

Fix dead links #524

logankilpatrick opened this issue Dec 24, 2019 · 8 comments

Comments

@logankilpatrick
Copy link
Sponsor Member

Resolves #156

See https://github.com/JuliaLang/www.julialang.org/commit/a795c88608690f9ea896408a6884e00145ae1ddf/checks?check_suite_id=373243536

for a list of all broken/dead links in the repo. These need to be updated with the appropriate links or have their content removed.

@ViralBShah
Copy link
Member

In some cases (of internal links) the stuff has probably moved to a new URL. For external broken links, it is worth seeing if there are updated links.

@abhishalya
Copy link
Contributor

abhishalya commented Dec 26, 2019

Dead links: https://gist.github.com/abhishalya/fabbc769e939fa25ff61cbdd42e5bc9f

Also, seems like we need a better link checker :P

@ViralBShah
Copy link
Member

ViralBShah commented Dec 26, 2019

Let's put these in a spreadsheet? I can provide updated links for most of these. Can probably just write a simple sed script to auto-replace the whole thing.

@logankilpatrick
Copy link
Sponsor Member Author

I made this a code in task and he’s going to update them in the morning, whether that be via a sed script or manually.

@logankilpatrick
Copy link
Sponsor Member Author

I’m not sure what a sed script is but it may be nice to have for future broken links.

@ViralBShah
Copy link
Member

ViralBShah commented Dec 26, 2019

Here's a spreadsheet with all the broken links.

https://docs.google.com/spreadsheets/d/1g-2o6JcSw-f_sBsMBScVWycrw0JxZsnZ7J9-YldW8WE/edit#gid=1563594672

What we need to do is to populate the second column with the replacement. Then it is trivial to write a simple script to replace the broken links in one shot. The script should be checked into the repo as well.

sed: https://www.gnu.org/software/sed/manual/sed.html#Overview

@ViralBShah
Copy link
Member

We should probably do similar check on julia docs as well.

@logankilpatrick
Copy link
Sponsor Member Author

Yep, will add a PR later today for this.

abhishalya added a commit to abhishalya/www.julialang.org that referenced this issue Dec 27, 2019
This fixes most of the dead/changed links if not all.
Some of the links have been removed since they were not
available anymore. Most of the links have been updated
to their corresponding new links.

Resolves JuliaLang#524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants