Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CUDA compat and add Metal #2108

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Update CUDA compat and add Metal #2108

merged 3 commits into from
Jun 7, 2024

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jun 6, 2024

cc @ViralBShah

I'm not sure shoehorning the GPU stuff in the existing table is the best way to go though. Maybe we need a separate table with accelerator-specific information (e.g., which GPU hardware) and their support tiers?

Copy link

github-actions bot commented Jun 6, 2024

Once the build has completed, you can preview your PR at this URL: https://julialang.netlify.app/previews/PR2108/ in ~15 minutes

@maleadt maleadt marked this pull request as draft June 6, 2024 13:20
@maleadt maleadt marked this pull request as ready for review June 6, 2024 13:49
@ViralBShah
Copy link
Member

ViralBShah commented Jun 6, 2024

I was thinking the same - it made sense shoehorning when we just had the CUDA stuff. It feels a bit strange now. Can you factor out the GPU support into a separate table?

Should Metal be 14+, given it is still early days for that package so we avoid legacy versions?

@maleadt maleadt marked this pull request as draft June 6, 2024 14:10
@maleadt maleadt marked this pull request as ready for review June 7, 2024 15:02
@maleadt
Copy link
Member Author

maleadt commented Jun 7, 2024

This is the new table:
image

@ViralBShah ViralBShah merged commit c53fc75 into main Jun 7, 2024
2 checks passed
@ViralBShah ViralBShah deleted the tb/gpu branch June 7, 2024 18:18
@ViralBShah
Copy link
Member

cc @jpsamaroo @vchuravy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants