Fix bug in colsupport with col-vec views (#62)

* Fix bug in colsupport with col-vec views * v0.6.5
JuliaLinearAlgebra · Apr 11, 2021 · ce37dcd · ce37dcd · dlfivefifty · Apr 11, 2021
1 parent 0273e85
commit ce37dcd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "ArrayLayouts"
 uuid = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
 authors = ["Sheehan Olver <solver@mac.com>"]
-version = "0.6.4"
+version = "0.6.5"
 
 [deps]
 FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"

diff --git a/src/memorylayout.jl b/src/memorylayout.jl
@@ -648,7 +648,7 @@ colsupport(A, j) = colsupport(MemoryLayout(A), A, j)
 colsupport(A) = colsupport(A, axes(A,2))
 
 # TODO: generalise to other subarrays
-function colsupport(A::SubArray{<:Any,N,<:Any,<:Tuple{Slice,Any}}, j) where N
+function colsupport(A::SubArray{<:Any,N,<:Any,<:Tuple{Slice,AbstractVector}}, j) where N
     _, jr = parentindices(A)
     colsupport(parent(A), jr[j])
 end

diff --git a/test/test_layouts.jl b/test/test_layouts.jl
@@ -428,4 +428,8 @@ struct FooNumber <: Number end
         MemoryLayout(revD)
         @test 0 == @allocated MemoryLayout(revD)
     end
+
+    @testset "bug in vec views BandedMatrices#233" begin
+        @test colsupport(view(randn(5,5),:,1),1:1) ≡ Base.OneTo(5)
+    end
 end