-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub actions #30
GitHub actions #30
Conversation
aminya
commented
Feb 14, 2020
- Adding Github actions CI: this will solve Windows CI problem of Appveyor
- Adding Tagbot
- Adding CompatHelper
.github/workflows/ci.yml
Outdated
@@ -0,0 +1,28 @@ | |||
name: CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A unified CI test instead of Appveyor (and Travis) that fails building Windows.
https://ci.appveyor.com/project/andreasnoack/mkl-jl/builds/30808306
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just use Travis (for all 3 OS).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is possible, but Github actions is IMO faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they are faster we should probably use it. If I merge this will it just start to become active? There are no new notifications from this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are based on my tests.
I think they should get active once merged. Probably it is because I am making a PR to your branch instead of Master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think they will pass though because the default test script is not suitable to test this packge (which is why I have the custom stuff in the .travis in the PR). Can we just first put in CompatHelper + TagBot and then we can deal with changing CI later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh OK. I am going to delete the file for now.