Use Scratch.jl for data dir; deprecate user dir #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is not clear to me, why you want to deprecate the user-defined generators without replacement. |
|
Yes, this PR was incomplete, as I had not yet written the documentation and tests surrounding the package-based replacement approach to user-defined generators. I agree that such a change should be a separate PR. Due to the issues I ran into in this PR regarding Requires.jl reinitializing MatrixDepot and confusing multiple changes to the default data directory, I am now advocating for the simpler approach in #75. Currently, #75 contains only changes to the data-dir. I will file a separate PR to #75 for the changes to user-defined generators. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#73 This PR avoids writing to the MatrixDepot repo by default when Scratch is loaded, and deprecates the user generator directory. Currently a work in progress.
When Scratch gets loaded after MatrixDepot, we reinitialize the data directory. I don't like this behavior, and I think it may be worth waiting on this PR until we can explicitly depend on Scratch.