Allow kwargs to pass to lldl #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The implementation looks correct to me. Please add a test and let's this get this merged. |
|
I added a minimal test. |
|
@mohamed82008 this is ready for you to review |
| @@ -2,26 +2,36 @@ function assert_pd(d, α) | |||
| @assert α == 0 && all(x -> x > 0, d) "The input matrix is not positive definite." | |||
| end | |||
|
|
|||
| """ | |||
| CholeskyPreconditioner(A, memory=2; kwargs...) | |||
| Construct | |||
There was a problem hiding this comment.
We should use JuliaFormatter at some point to have consistent formatting. The lack of an empty line before Construct and short docstring lines strike me as odd but it's not a blocker. I am happy to follow any standard automated format.
mohamed82008
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #30.
I have not yet added and tests to confirm the additional functionality.
@learning-chip does this seem like the appropriate extension and can you suggest a test?