Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.jl #4

Merged
merged 1 commit into from
Dec 26, 2018
Merged

Update build.jl #4

merged 1 commit into from
Dec 26, 2018

Conversation

mohamed82008
Copy link
Member

This PR removes unnecessary legacy build instructions. This was pointed out in #3.

remove unnecessary legacy build instructions
@coveralls
Copy link

Pull Request Test Coverage Report for Build 25

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.545%

Totals Coverage Status
Change from base Build 22: 0.0%
Covered Lines: 36
Relevant Lines: 66

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 25

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.545%

Totals Coverage Status
Change from base Build 22: 0.0%
Covered Lines: 36
Relevant Lines: 66

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Dec 26, 2018

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   54.54%   54.54%           
=======================================
  Files           4        4           
  Lines          66       66           
=======================================
  Hits           36       36           
  Misses         30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 023ed3e...50e74ec. Read the comment docs.

@mohamed82008 mohamed82008 merged commit 470a301 into master Dec 26, 2018
@mohamed82008 mohamed82008 deleted the mohamed82008-patch-1 branch December 26, 2018 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants