Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy, lmul! and rmul! methods #8

Merged
merged 7 commits into from
Oct 27, 2022
Merged

Add copy, lmul! and rmul! methods #8

merged 7 commits into from
Oct 27, 2022

Conversation

dmbates
Copy link
Contributor

@dmbates dmbates commented Oct 3, 2022

  • Add a copy method for HermitianRFP. The other two types, TriangularRFP and CholeskyRFP, had a copy method but not Hermitian.

  • Add methods for lmul! and rmul! that amount to an in-place scaling. The matrix argument in the signature is specified as AbstractRFP. Is this inefficient?

  • Add a method for BLAS.syrk! with HermitianRFP.

  • The choice of methods to define is influenced by what I need for the MixedModels package I will leave this as a draft PR until I finish with incorporating RFP storage in that package.

@dmbates dmbates marked this pull request as draft October 3, 2022 20:22
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 97.04% // Head: 97.26% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (4536834) compared to base (040521b).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 4536834 differs from pull request most recent head 7545ae3. Consider uploading reports for the commit 7545ae3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   97.04%   97.26%   +0.22%     
==========================================
  Files           5        5              
  Lines         169      183      +14     
==========================================
+ Hits          164      178      +14     
  Misses          5        5              
Impacted Files Coverage Δ
src/cholesky.jl 100.00% <100.00%> (ø)
src/hermitian.jl 95.65% <100.00%> (+1.90%) ⬆️
src/triangular.jl 100.00% <100.00%> (ø)
src/utilities.jl 97.43% <100.00%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmbates dmbates marked this pull request as ready for review October 7, 2022 20:19
@dmbates
Copy link
Contributor Author

dmbates commented Oct 7, 2022

I'm happy to add other method definitions in this PR if you can think of any that you would want. As I mentioned in the description of the PR, the ones I chose to include were dictated by what I needed in another package.

@dmbates
Copy link
Contributor Author

dmbates commented Oct 27, 2022

@andreasnoack Is it okay to merge this PR?

Copy link
Member

@andreasnoack andreasnoack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this PR. Yes, it looks good to me.

@dmbates dmbates merged commit 9ca6c3d into main Oct 27, 2022
@dmbates dmbates deleted the copymethods branch October 27, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants