Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger dispatch for SampleBuf type #29

Open
shashikdm opened this issue May 22, 2019 · 3 comments
Open

Logger dispatch for SampleBuf type #29

shashikdm opened this issue May 22, 2019 · 3 comments

Comments

@shashikdm
Copy link
Contributor

Unsure whether to implement Logger dispatch for SampleBuf. It will result in SampledSignals dependency.
https://github.com/JuliaAudio/SampledSignals.jl/blob/master/src/SampleBuf.jl
#27
@PhilipVinc
Copy link
Member

What about using Requires.jl ?

@shashikdm
Copy link
Contributor Author

shashikdm commented May 22, 2019 •
edited
Loading

That is a nice idea. It'll be helpful with ImageCore, StatsBase, FileIO as well. @oxinabox What is your opinion?

@oxinabox
Copy link
Member

Requires.jl is really nice for this in theory.
However, in practice it is incredibly slow, because of how it forces the world to stop to run the compiler.
Also we don't have a great way to handle versions in it AFAIK,

so I would hold off on doing that til other things are done.

@oxinabox oxinabox mentioned this issue May 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PhilipVinc @oxinabox @shashikdm