Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add native support for Gadfly plots #127

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Conversation

nomadbl
Copy link
Contributor

@nomadbl nomadbl commented Jul 3, 2023

Add native Gadfly plot support.
Includes a new usage example and docstrings.

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really should move all these over to Julia 1.9's extension modules / weak deps
Those can work in 1.8 too, so we would only have to restrict compat to 1.8+

I will grant you merge rights shortly so feel free to merge this when happy

nomadbl and others added 2 commits July 7, 2023 15:25
assertions may be removed depending how optiions are set

Co-authored-by: Frames White <oxinabox@ucc.asn.au>
@nomadbl
Copy link
Contributor Author

nomadbl commented Jul 10, 2023

Merging this. There is an unfortunate annoying print to stdout when the plots are displayed, but this is a Gadfly/Compose issue (see GiovineItalia/Gadfly.jl#1621 and GiovineItalia/Compose.jl#440)

@nomadbl nomadbl merged commit ded3fc5 into JuliaLogging:master Jul 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants