Call svm_check_parameter before training
#72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 81.86% 83.94% +2.08%
==========================================
Files 4 4
Lines 215 218 +3
==========================================
+ Hits 176 183 +7
+ Misses 39 35 -4
Continue to review full report at Codecov.
|
iblislin
reviewed
Jun 9, 2021
iblislin
reviewed
Jun 9, 2021
iblislin
reviewed
Jun 9, 2021
|
Let's put aside the |
barucden
force-pushed
the
check_parameter
branch
3 times, most recently
from
736d3fe
to
7e6dd05
Compare
LIBSVM provides function `svm_check_parameter` that validates the parameters given by `SVMParameter`. This commit calls this function before calling `svm_train`.
|
@iblis17 Thanks for the review. The changes are implemented now. |
iblislin
reviewed
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LIBSVM provides function
svm_check_parameterthat validates the parameters given bySVMParameter. This PR calls this function before callingsvm_train.It also removes one unused return value.