Wrap ccalls with proper Julia functions
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following JuliaML#75, this commit wraps all calls to the LIBSVM C library with proper Julia functions. That way we get some type safety and it also makes the code cleaner.
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
- Coverage 84.01% 82.88% -1.14%
==========================================
Files 4 5 +1
Lines 219 222 +3
==========================================
Hits 184 184
- Misses 35 38 +3
Continue to review full report at Codecov.
|
iblislin
reviewed
Jun 11, 2021
iblislin
reviewed
Jun 11, 2021
iblislin
reviewed
Jun 11, 2021
iblislin
reviewed
Jun 11, 2021
iblislin
reviewed
Jun 11, 2021
Co-authored-by: Iblis Lin <iblis.dif01@nctu.edu.tw>
iblislin
added a commit
that referenced
this pull request
Jun 11, 2021
Co-authored-by:Denis Barucic <barucden@fel.cvut.cz>
iblislin
added a commit
that referenced
this pull request
Jun 11, 2021
Co-authored-by: Denis Barucic <barucden@fel.cvut.cz>
Merged
iblislin
added a commit
that referenced
this pull request
Jun 11, 2021
Co-authored-by: Iblis Lin <iblis@hs.ntnu.edu.tw>
This adds a test for decision values and fixes passing the pointer to the decision value array.
|
@iblis17 I did what you suggested about the decision values. We now have a basic test to check the decision values too. I will try to tackle the pointers later, but I think this one is ready for merge. |
iblislin
reviewed
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #75, this PR wraps all calls to the LIBSVM C library with proper Julia functions. That way we get some type safety and it also makes the code cleaner.