This repository has been archived by the owner on May 23, 2022. It is now read-only.

deprecate obs_dim in favour of convert #24

Merged

Evizero merged 1 commit into master from obsdim

Apr 6, 2017

Member

Evizero commented Apr 5, 2017

This seems much cleaner

function foo(X, arg1, arg2; obsdim = LearnBase.default_obsdim(X))
    foo(X, arg1, arg2, convert(LearnBase.ObsDimension, obsdim))
end


          deprecate obs_dim in favour of convert

0ba08eb

coveralls commented Apr 5, 2017

Coverage remained the same at 100.0% when pulling 0ba08eb on obsdim into a14b4e6 on master.

Evizero merged commit 984724e into master

Evizero deleted the obsdim branch

April 6, 2017 10:26

Evizero mentioned this pull request

update LearnBase - change obs_dim to convert JuliaML/MLLabelUtils.jl#9

Merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.