Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #125

Merged
merged 6 commits into from Apr 7, 2020
Merged

Update docs #125

merged 6 commits into from Apr 7, 2020

Conversation

juliohm
Copy link
Member

@juliohm juliohm commented Apr 5, 2020

This PR updates the docs to use Project.toml and a newer version of Documenter.jl. It also adds a new subsection covering the other losses available that do not fit the distance-based nor margin-based definition.

Fix #111

@juliohm
Copy link
Member Author

juliohm commented Apr 5, 2020

It may depend on merging #124 first. Appreciate if you can review.

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that one comment LGTM.
Merge once addressed?

docs/Manifest.toml Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Apr 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@9df99f6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #125   +/-   ##
=========================================
  Coverage          ?   90.30%           
=========================================
  Files             ?       12           
  Lines             ?      712           
  Branches          ?        0           
=========================================
  Hits              ?      643           
  Misses            ?       69           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9df99f6...69304c9. Read the comment docs.

@juliohm juliohm merged commit c77f3b7 into JuliaML:master Apr 7, 2020
@juliohm juliohm deleted the docs branch April 7, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs don't include all available loss functions
4 participants