Stick to a single interface #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi everyone, appreciate if you can review this. I am free today to keep working on further improvements after this PR is merged. |
oxinabox
reviewed
Apr 10, 2020
oxinabox
approved these changes
Apr 10, 2020
Co-Authored-By: Lyndon White <lyndon.white@invenialabs.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements all the necessary modifications to address items (1) and (2) in #126. I appreciate if you can review it so that we can move forward with the generalization of a single interface.
In terms of deprecation strategies, what should we do in deprecated.jl? Can we eliminate some of the old deprecations there and add new ones for the changes in this PR?