Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loss-properties documentation. #76

Closed
wants to merge 13 commits into from

Conversation

kumarkrishna
Copy link
Contributor

Completes #74 and fixes #73 .

@Evizero
Copy link
Member

Evizero commented Feb 4, 2017

very nice! I think we will have a merge conflict though because just two hours ago I made some changes to the convex documentation. I just pushed that. Could you maybe look into fixing the conflict on your end (with a rebase)? Basically what I changed is some typing and I added the reference to the Boyd book from which the definition seems to be taken out of

@Evizero
Copy link
Member

Evizero commented Feb 4, 2017

actually I'll look into it right now

@Evizero
Copy link
Member

Evizero commented Feb 4, 2017

Ok, thanks! I rebased your new commits and added them to the dev branch (so they are already merged now and I will close this PR).

@Evizero Evizero closed this Feb 4, 2017
@Evizero
Copy link
Member

Evizero commented Feb 4, 2017

There seem to be some type-setting issues (which I may have introduced in the process). I'll take care of them. thanks again

@kumarkrishna
Copy link
Contributor Author

Thanks! I've taken some definitions from the Steinwart book too, so it would probably be a good idea to put in a reference. Also, isclasscalibrated has a slightly more involved documentation, so I'll add that today and cover all the properties.

@Evizero
Copy link
Member

Evizero commented Feb 5, 2017

I just pushed my changes to the properties to the dev branch. http://lossesjl.readthedocs.io/en/dev/losses/interface.html#properties-of-a-loss. mostly type-setting fixes, and some notation simplification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants