streamline OrdinalMarginLoss construction #89
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we ended up not doing the unrolling, it seems more flexible to not make
N
a type var. This way its cleaner forN
to depend on the data.Aside from this, I wrote the constructor of
OrdinalMarginLoss
such that its easy to define clean typealiases.For example the following is possible:
Since
HingeLoss
has no free parameters the above is quite simple, but the construction even works for allMarginLoss
that do have free paramaters, such as theSmoothedL1HingeLoss
cc: @mihirparadkar