New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Faust Dataset #160
Add Faust Dataset #160
Conversation
The unit test is causing problems because it cannot download from UCI archives. |
@CarloLucibello should we remove the failing changes? I believe the CI downloading dataset is most likely flagged as bot download. |
I'm not sure why we have an error with the |
1 similar comment
I'm not sure why we have an error with the |
Cool |
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
==========================================
- Coverage 33.62% 32.03% -1.60%
==========================================
Files 40 42 +2
Lines 2028 2132 +104
==========================================
+ Hits 682 683 +1
- Misses 1346 1449 +103
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
the 1.6 test failure seems real. Not sure which escape sequence is invalid on julia 1.6 though |
The problem is backslashes in lines 36-42 breaking two lines. Breaklines compatibility changed in 1.7 as understood from this discourse thread. It would be better to just use longer lines for now to let all the tests pass. |
can we do this and complete this PR? |
Version Bump for this :0 |
Closes #155