generalize batchseq to sequence of generic arrays #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #126 +/- ##
==========================================
+ Coverage 88.77% 88.94% +0.17%
==========================================
Files 13 13
Lines 561 570 +9
==========================================
+ Hits 498 507 +9
Misses 63 63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
etpinard
reviewed
Oct 24, 2022
Comment on lines
+143
to
+146
| batchseq([ones(2,4), zeros(2, 3), ones(2,2)]) ==[[1.0 0.0 1.0; 1.0 0.0 1.0] | ||
| [1.0 0.0 1.0; 1.0 0.0 1.0] | ||
| [1.0 0.0 0.0; 1.0 0.0 0.0] | ||
| [1.0 0.0 0.0; 1.0 0.0 0.0]] |
There was a problem hiding this comment.
this behaviour looks good to me (author of #118) - thanks 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the following behavior for
batchseq: Given an input list xs containing B arrays of size* x Li, where * is common to all arrays andLican vary, return a list of length Lmax where the elements have size* x B.Have to depend on
NNlibfor this, not sure it is worth it.Also, we deprecate
rpadsince it is piracy of a Base function in favor of a more genericrpad_constant(mimicking the NNlib naming scheme).Fix #118