Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to chunk #133

Merged
merged 7 commits into from
Dec 28, 2022
Merged

improvements to chunk #133

merged 7 commits into from
Dec 28, 2022

Conversation

CarloLucibello
Copy link
Member

@CarloLucibello CarloLucibello commented Dec 28, 2022

  • make chunk accept a collection of sizes
  • use view instead of selectdim in order to improve returned type for cuda arrays

Fix #114, fix #103

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2022

Codecov Report

Merging #133 (f8c8f51) into main (08ad0b7) will decrease coverage by 0.43%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   88.61%   88.18%   -0.44%     
==========================================
  Files          13       15       +2     
  Lines         571      584      +13     
==========================================
+ Hits          506      515       +9     
- Misses         65       69       +4     
Impacted Files Coverage Δ
src/utils.jl 89.70% <89.47%> (-0.70%) ⬇️
src/Datasets/Datasets.jl 0.00% <0.00%> (ø)
src/MLUtils.jl 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@CarloLucibello CarloLucibello changed the title make chunk accept a collection of sizes improvements to chunk Dec 28, 2022
@CarloLucibello CarloLucibello merged commit 6a86d23 into main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend chunk to take a Vector of sizes chunk returns views for CuArrays
2 participants