-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default parallel executor to ThreadedEx
#143
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #143 +/- ##
==========================================
+ Coverage 88.28% 88.50% +0.21%
==========================================
Files 15 15
Lines 589 600 +11
==========================================
+ Hits 520 531 +11
Misses 69 69
|
We would need to make sure this doesn't reintroduce the problem #80 was trying to address. |
As mentioned in #142, let's do this. Before merging, I'd like to add the following comments:
In any case, some up-to-date benchmarks comparing the two would be nice, but seeing the mounting issues with |
Sorry, didn't realize this was waiting for my input.
I haven't seen that personally. Perhaps for specific workloads one can come up with a more optimized |
Some checks related to printing fail on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you adjust the version?
cc508f6
to
112315d
Compare
Done. However, I'm a bit confused why the git diff here on github shows going from version 0.4.0 to 0.4.3, even though the master branch is already on 0.4.2 (?). |
Okay now it is showing conflicts (presumably because you touched a file changed on |
Done. Thanks for bearing with me! |
Thank you! |
Closes #142