Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RNG support to randobs #162

Merged
merged 0 commits into from
Dec 30, 2023
Merged

Add RNG support to randobs #162

merged 0 commits into from
Dec 30, 2023

Conversation

EssamWisam
Copy link

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #162 (abb846c) into main (03f8fb1) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   88.50%   88.53%   +0.03%     
==========================================
  Files          15       15              
  Lines         600      602       +2     
==========================================
+ Hits          531      533       +2     
  Misses         69       69              
Impacted Files Coverage Δ
src/randobs.jl 100.00% <100.00%> (ø)

@CarloLucibello
Copy link
Member

let's mimick the rand etc interface and have randobs([rng], data, ...)

@EssamWisam
Copy link
Author

EssamWisam commented Jul 13, 2023

let's mimick the rand etc interface and have randobs([rng], data, ...)

Alright.

@CarloLucibello CarloLucibello merged commit 09c87f7 into JuliaML:main Dec 30, 2023
82 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants