Add firstindex(::AbstractDataContainer)
#164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the `begin` keyword when indexing an `AbstractDataContainer`. Note that `end` already worked when indexing because of `lastindex(::AbstractDataContainer)` is already implemented. For example: ```julia julia> using MLDatasets julia> mnist = MNIST() julia> x, y = mnist[begin] (features = Float32[0.0 0.0 … 0.0 0.0; 0.0 0.0 … 0.0 0.0; … ; 0.0 0.0 … 0.0 0.0; 0.0 0.0 … 0.0 0.0], targets = 5) ```
|
Could you add a test? Maybe one that uses |
Codecov Report
@@ Coverage Diff @@
## main #164 +/- ##
==========================================
+ Coverage 88.50% 88.51% +0.01%
==========================================
Files 15 15
Lines 600 601 +1
==========================================
+ Hits 531 532 +1
Misses 69 69
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the
beginkeyword when indexing anAbstractDataContainer. Note thatendalready worked when indexingbecause of
lastindex(::AbstractDataContainer)is already implemented. For example: