Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please move colspec.jl to the root folder #36

Closed
juliohm opened this issue Apr 4, 2022 · 4 comments
Closed

Please move colspec.jl to the root folder #36

juliohm opened this issue Apr 4, 2022 · 4 comments
Assignees
@eliascarv

Comments

@juliohm
Copy link
Member

juliohm commented Apr 4, 2022

I noticed that you added colspec.jl to the transforms folder, but it is not a transform @eliascarv. Can you please move it to the root folder and update the include?
@eliascarv
Copy link
Member

OK, I will do it

@juliohm
Copy link
Member Author

juliohm commented Apr 9, 2022

@eliascarv appreciate if you can take a look at this now that we merged the PR you were working on. 💯

@eliascarv
Copy link
Member

OK, I will do it now!

@juliohm juliohm mentioned this issue Apr 10, 2022
Merged
@juliohm juliohm closed this as completed Apr 10, 2022
@juliohm
Copy link
Member Author

juliohm commented Apr 10, 2022

This issue is now fixed. I think we also need to rename _filter to a public function name to be used by other transforms. I will open a separate issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eliascarv eliascarv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juliohm @eliascarv