Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move colspec and rename arguments #38

Merged
merged 4 commits into from
Apr 10, 2022
Merged

Move colspec and rename arguments #38

merged 4 commits into from
Apr 10, 2022

Conversation

eliascarv
Copy link
Member

@eliascarv eliascarv commented Apr 9, 2022

This PR moves the colspec file to src and renames cols to names for consistency with the rest of the code.

@codecov-commenter
Copy link

Codecov Report

Merging #38 (59b8163) into master (68e89ba) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files          16       16           
  Lines         431      431           
=======================================
  Hits          399      399           
  Misses         32       32           
Impacted Files Coverage Δ
src/transforms.jl 97.82% <ø> (ø)
src/colspec.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e89ba...59b8163. Read the comment docs.

src/transforms.jl Outdated Show resolved Hide resolved
@juliohm
Copy link
Member

juliohm commented Apr 10, 2022

Fix #36

@juliohm juliohm merged commit ab30ce9 into JuliaML:master Apr 10, 2022
@eliascarv eliascarv deleted the move-colspec branch April 10, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants