Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename _filter to a public function name in ColSpec #39

Closed
juliohm opened this issue Apr 10, 2022 · 5 comments
Closed

Rename _filter to a public function name in ColSpec #39

juliohm opened this issue Apr 10, 2022 · 5 comments
Assignees

Comments

@juliohm
Copy link
Member

juliohm commented Apr 10, 2022

Currently we write _filter(spec, names) in the transforms. Maybe we should rename _filter to a name without underscore to signal that it is part of a "public" api of ColSpec.

@eliascarv
Copy link
Member

OK.
We can't use filter because it's a base function. So we have to think of another name for this function.
What do you think of selnames?

@juliohm
Copy link
Member Author

juliohm commented Apr 11, 2022

What about choose(spec, cols)?

@eliascarv
Copy link
Member

I think 'choose' is a good name. We must chage 'colspec' to 'spec'?
snames = choose(spec, names)

@juliohm
Copy link
Member Author

juliohm commented Apr 11, 2022

I think colspec is fine if it is already the term used in the current implementation and use cases of the function.

@eliascarv
Copy link
Member

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants