-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename _filter to a public function name in ColSpec #39
Comments
OK. |
What about |
I think 'choose' is a good name. We must chage 'colspec' to 'spec'? |
I think colspec is fine if it is already the term used in the current implementation and use cases of the function. |
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we write _filter(spec, names) in the transforms. Maybe we should rename _filter to a name without underscore to signal that it is part of a "public" api of ColSpec.
The text was updated successfully, but these errors were encountered: