Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename _filter to choose and create colspec.jl file in test folder #41

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Rename _filter to choose and create colspec.jl file in test folder #41

merged 2 commits into from
Apr 12, 2022

Conversation

eliascarv
Copy link
Member

@eliascarv eliascarv commented Apr 12, 2022

This PR renames _filter to choose and moves ColSpec tests to colspec.jl file.

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #41 (084a6ef) into master (ab30ce9) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   92.57%   92.67%   +0.10%     
==========================================
  Files          16       17       +1     
  Lines         431      437       +6     
==========================================
+ Hits          399      405       +6     
  Misses         32       32              
Impacted Files Coverage Δ
src/colspec.jl 100.00% <100.00%> (ø)
src/transforms/filter.jl 98.00% <100.00%> (ø)
src/transforms/select.jl 91.30% <100.00%> (ø)
src/transforms/coalesce.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab30ce9...084a6ef. Read the comment docs.

@eliascarv eliascarv requested a review from juliohm April 12, 2022 00:45
Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR as usual.

test/runtests.jl Outdated Show resolved Hide resolved
@juliohm
Copy link
Member

juliohm commented Apr 12, 2022

Fix #39

@juliohm juliohm merged commit d1fd5ec into JuliaML:master Apr 12, 2022
@eliascarv eliascarv deleted the choose branch April 12, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants