Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation with Documenter.jl #43

Closed
juliohm opened this issue Apr 13, 2022 · 13 comments
Closed

Add documentation with Documenter.jl #43

juliohm opened this issue Apr 13, 2022 · 13 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@juliohm
Copy link
Member

juliohm commented Apr 13, 2022

The project has grown a lot with the latest additions by @eliascarv and @ceferisbarov ❤️ I think it is time to add a documentation page with Documenter.jl.

In my opinion an ideal documentation for this package would consist of two pages:

  1. A page with the examples from the README and other examples showing revertibility of pipelines.
  2. A page with a list of docstrings for all available transforms and an index table (or side page) that users could click to jump directly to any transform's docstring.

We can then focus on writing very good docstrings and never bother again about updating the documentation. Any newly added transform could just be appended to the docstring page.

@juliohm juliohm added the documentation Improvements or additions to documentation label Apr 13, 2022
@ceferisbarov
Copy link
Contributor

I would like to learn Documenter.jl and work on this issue, if it is not very urgent.

@juliohm
Copy link
Member Author

juliohm commented Apr 13, 2022

Hi @ceferisbarov it would be nice if you could align with @eliascarv to review all docstrings systematically before the Documenter.jl part. We have a roadmap that consists of:

  1. Reviewing all docstrings of all transforms to improve clarity and short examples when that is possible.
  2. Creating the documentation page with Documenter.jl with the two pages described above.

Feel free to coordinate between each other a subset of docstrings to review. We could then review multiple PRs in paralell. That would be great.

@juliohm juliohm added the good first issue Good for newcomers label Apr 14, 2022
@eliascarv
Copy link
Member

eliascarv commented Apr 15, 2022

List of docstrings that should be improved:

@eliascarv:

  • choose
  • Select
  • Reject
  • Filter
  • DropMissing

@ceferisbarov:

  • Rename
  • Replace
  • Coalesce
  • Coerce
  • Identity

@eliascarv:

  • Center
  • Scale
  • MinMax
  • Interquartile
  • ZScore

@ceferisbarov:

  • Quantile
  • Functional
  • EigenAnalysis / PCA / DRS / SDS
  • Sequential
  • Parallel

@eliascarv
Copy link
Member

@ceferisbarov we'll share this work between us. Each PR must update 5 docstrings.

@ceferisbarov
Copy link
Contributor

ceferisbarov commented Apr 15, 2022 via email

@eliascarv
Copy link
Member

List of docstrings that should be improved:

@eliascarv:

...

Here I have separated the docstrings into groups of 5 and assigned each one to one of us.

@ceferisbarov
Copy link
Contributor

ceferisbarov commented Apr 15, 2022 via email

@eliascarv
Copy link
Member

No problems

@juliohm
Copy link
Member Author

juliohm commented Apr 20, 2022

We finished two batches of updates. Only two more to go.

@juliohm
Copy link
Member Author

juliohm commented Apr 23, 2022

Awesome progress, now we just miss the final batch of transforms before adding all of them to the Documenter.jl page. Do you think you can work on that @ceferisbarov ?

@ceferisbarov
Copy link
Contributor

@juliohm Yes, I opened a PR.

@juliohm
Copy link
Member Author

juliohm commented Apr 23, 2022

Thank you! Now we can proceed and add a page to the documentation with all transforms listed in a @docs block. @eliascarv can you work on that? We have examples in Meshes.jl and GeoStats.jl of such blocks. We can call this page the reference guide.

@juliohm
Copy link
Member Author

juliohm commented Apr 28, 2022

Awesome work!

@juliohm juliohm closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants