Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexport internal types and functions #53

Closed
eliascarv opened this issue Apr 24, 2022 · 1 comment · Fixed by #57
Closed

Unexport internal types and functions #53

eliascarv opened this issue Apr 24, 2022 · 1 comment · Fixed by #57

Comments

@eliascarv
Copy link
Member

eliascarv commented Apr 24, 2022 •
edited
Loading

This types:

Transform, Stateless, Colwise

and this functions:

assertions, colapply, colrevert

are part of the internal API and should not be exported.
@juliohm
Copy link
Member

juliohm commented Apr 28, 2022

Maybe it is still useful to export Transform for multiple dispatch? So that users of the transforms can dispatch on any kind of transform. What do you think?

@eliascarv eliascarv mentioned this issue Apr 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unexport internal types and functions; Remove unnecessary example JuliaML/TableTransforms.jl
2 participants
@juliohm @eliascarv