Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexport internal types and functions; Remove unnecessary example #57

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

eliascarv
Copy link
Member

@eliascarv eliascarv commented Apr 28, 2022

closes #53

@eliascarv eliascarv requested a review from juliohm April 28, 2022 00:46
Comment on lines -9 to -14

# Examples

```julia
Identity()
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended? The PR is about removing exports right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's such a small change that I thought it could be included in this PR.
Want me to do a PR for this change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, just wanted to double check it was an intentional change. 👍🏽

@juliohm juliohm merged commit c50d658 into master Apr 28, 2022
@juliohm juliohm deleted the unexport branch April 28, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexport internal types and functions
2 participants