Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Indicator transform #181

Merged
merged 13 commits into from
Aug 22, 2023
Merged

Add Indicator transform #181

merged 13 commits into from
Aug 22, 2023

Conversation

eliascarv
Copy link
Member

@eliascarv eliascarv commented Aug 21, 2023

closes #177

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #181 (459d0b4) into master (a0e4284) will increase coverage by 0.24%.
Report is 3 commits behind head on master.
The diff coverage is 96.15%.

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
+ Coverage   91.39%   91.63%   +0.24%     
==========================================
  Files          29       30       +1     
  Lines         941      992      +51     
==========================================
+ Hits          860      909      +49     
- Misses         81       83       +2     
Files Changed Coverage Δ
src/TableTransforms.jl 100.00% <ø> (ø)
src/transforms.jl 98.61% <ø> (ø)
src/transforms/indicator.jl 96.07% <96.07%> (ø)
src/transforms/onehot.jl 100.00% <100.00%> (ø)

Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. We just need tests to merge it.

src/transforms/indicator.jl Outdated Show resolved Hide resolved
src/transforms/indicator.jl Outdated Show resolved Hide resolved
src/transforms/indicator.jl Outdated Show resolved Hide resolved
@eliascarv eliascarv changed the title [WIP] Add Indicator transform Add Indicator transform Aug 22, 2023
@eliascarv eliascarv marked this pull request as ready for review August 22, 2023 13:41
@eliascarv eliascarv requested a review from juliohm August 22, 2023 13:42
src/transforms/indicator.jl Outdated Show resolved Hide resolved
src/transforms/indicator.jl Outdated Show resolved Hide resolved
src/transforms/indicator.jl Outdated Show resolved Hide resolved
eliascarv and others added 2 commits August 22, 2023 10:47
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
@juliohm juliohm merged commit cfbf7ef into master Aug 22, 2023
8 checks passed
@juliohm juliohm deleted the indicator branch August 22, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicator
3 participants