Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom transforms docs example #191

Merged
merged 19 commits into from
Sep 4, 2023
Merged

Fix custom transforms docs example #191

merged 19 commits into from
Sep 4, 2023

Conversation

EssamWisam
Copy link
Contributor

Last time when I worked on the docs, I misused Tables.materialize without noticing. When I ran the example, for some reason, Tables.jl did not return an error and instead returned the original table and I didn't notice that anything is wrong because I didn't focus on the specific numbers.

This issue is solved in the PR.

EssamWisam and others added 18 commits August 22, 2023 01:25
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
This reverts commit c10e448.
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2023

Codecov Report

Merging #191 (c2b365b) into master (d2334a1) will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   92.22%   92.40%   +0.18%     
==========================================
  Files          31       31              
  Lines        1067     1067              
==========================================
+ Hits          984      986       +2     
+ Misses         83       81       -2     

see 1 file with indirect coverage changes

docs/make.jl Outdated Show resolved Hide resolved
@juliohm juliohm merged commit 40e27e3 into JuliaML:master Sep 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants